make ansible-lint common.yaml happy

roles/haproxy/handlers/main.yaml

@@ -1,17 +1,18 @@
 ---
 
 - name: restart haproxy
-  service:
+  systemd:
     name: haproxy
     state: restarted
 
 - name: reload haproxy
-  service:
+  systemd:
     name: haproxy
     state: reloaded
 
 - name: reload systemd config
-  shell: systemctl daemon-reload
+  systemd:
+    state: daemon-reload
 
 - name: update certs
-  shell: /usr/local/bin/update_haproxy_certs.sh
+  command: /usr/local/bin/update_haproxy_certs.sh

roles/haproxy/tasks/main.yaml

@@ -5,7 +5,7 @@
     name:
       - liblua5.3-0
       - libpcre3
-    state: latest
+    state: present
 
 - name: conflicted with haproxy package
   apt:
@@ -24,6 +24,7 @@
   file:
     path: "{{ item }}"
     state: directory
+    mode: 0755
   with_items:
     - /etc/haproxy/
     - /etc/haproxy/certs/
@@ -33,6 +34,7 @@
   copy:
     src: errorfiles
     dest: /etc/haproxy/
+    mode: 0644
 
 - name: copy haproxy binary
   copy:
@@ -91,13 +93,13 @@
   cron:
     name: renew certificates
     weekday: SUN
-    minute: "{{59|random(seed=inventory_hostname+'renew certificates')}}"
-    hour: "{{23|random(seed=inventory_hostname+'renew certificates')}}"
+    minute: "{{ 59|random(seed=inventory_hostname+'renew certificates') }}"
+    hour: "{{ 23|random(seed=inventory_hostname+'renew certificates') }}"
     job: /usr/local/bin/update_haproxy_certs.sh
 
 - name: renew ocsp information
   cron:
     name: renew ocsp
-    minute: "{{59|random(seed=inventory_hostname+'renew ocsp')}}"
-    hour: "{{23|random(seed=inventory_hostname+'renew ocsp')}}"
+    minute: "{{ 59|random(seed=inventory_hostname+'renew ocsp') }}"
+    hour: "{{ 23|random(seed=inventory_hostname+'renew ocsp') }}"
     job: /usr/local/bin/ocsp_update.sh